Skip to content

🎨Computational backend: improvements step 5 #8396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2025
Merged

🎨Computational backend: improvements step 5 #8396

merged 1 commit into from
Sep 19, 2025

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Sep 19, 2025 •
edited
Loading

What do these changes do?

Access to the clusters-keeper does not need to be bounded, only the access to the dask-scheduler.

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Cheops milestone Sep 19, 2025
@sanderegg sanderegg self-assigned this Sep 19, 2025
@sanderegg sanderegg added a:director-v2 issue related with the director-v2 service a:computational clusters labels Sep 19, 2025
@codecov
Copy link

codecov bot commented Sep 19, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.63%. Comparing base (53f823f) to head (f82f80d).
⚠️ Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (53f823f) and HEAD (f82f80d). Click for more details.

HEAD has 31 uploads less than BASE
Flag BASE (53f823f) HEAD (f82f80d)
unittests 32 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #8396       +/-   ##
===========================================
- Coverage   87.89%   68.63%   -19.27%     
===========================================
  Files        1951      761     -1190     
  Lines       75954    35028    -40926     
  Branches     1336      175     -1161     
===========================================
- Hits        66763    24042    -42721     
- Misses       8791    10929     +2138     
+ Partials      400       57      -343
Flag Coverage Δ
integrationtests 63.99% <100.00%> (+0.05%) ⬆️
unittests 84.59% <100.00%> (-2.00%) ⬇️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.69% <ø> (-8.25%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 91.02% <100.00%> (+0.10%) ⬆️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 81.87% <ø> (-8.59%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 58.77% <ø> (-29.17%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53f823f...f82f80d. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for f82f80d.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI integration-tests Base branch is broken, but retries were needed. Could be early signs of flakiness 👀 Broken 1 View View
system-tests Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀 Healthy 1 View View
unit-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@sanderegg sanderegg marked this pull request as ready for review September 19, 2025 13:26
@sanderegg sanderegg force-pushed the computational-backend/performnace-improvements-step5 branch from 4058ff7 to f82f80d Compare September 19, 2025 13:28
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 19, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sanderegg sanderegg merged commit a26142b into ITISFoundation:master Sep 19, 2025
141 of 148 checks passed
@sanderegg sanderegg deleted the computational-backend/performnace-improvements-step5 branch September 19, 2025 14:16
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 24, 2025
Closed
65 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov is a code owner

@wvangeit wvangeit Awaiting requested review from wvangeit

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@sanderegg sanderegg

Labels

a:computational clusters a:director-v2 issue related with the director-v2 service

Projects

None yet

Milestone

Cheops

Development

Successfully merging this pull request may close these issues.

2 participants

@sanderegg @GitHK